search

PayHelper / payum-mollie

The Payum extension which provides Mollie payment integration.
GNU General Public License v3.0
6 stars 6 forks source link

Create payment without specify any method #1

Closed link911 closed 4 years ago

link911 commented 5 years ago

Hello,

It will be useful to create a payment without specify method it at Symfony level but use configuration defined in Mollie console.

Why do not let Mollie to decide what payment method the client want to use? In case? The payment method "creditcard" in your bundle could be replaced to a generic empty method. The customer will be forward to Mollie checkout page and he could choice credit card method (if enabled) or any enabled payment method.

The only thing to do is remove the 'method' parameter in PayHelper\Payum\Mollie\Action\Api\CreateCaptureAction file and a very light refacto of PayHelper\Payum\Mollie\Action at the end of execute() method.

These modifications should help to implement a generic implementation of Mollie.

Thanks for your work :)

Regards

takeit commented 5 years ago

Hi @link911,

feel free to create a Pull Request! 👍

link911 commented 5 years ago

It's done. Must i do another thing to validate merge request? (first merge request ever ^^)

takeit commented 4 years ago

Resolved by #2