PayHereLK / payhere-mobilesdk-flutter

PayHere Mobile SDK for Flutter
BSD 3-Clause "New" or "Revised" License
5 stars 16 forks source link

make into federated plugin (add web support) #9

Open iwalpola opened 3 years ago

iwalpola commented 3 years ago

hi, I've been in touch via the customer support. please integrate my changes for web support There are 3 packages that need to be created on pub.dev

Suggested steps-->

  1. fork: Package 1: main package, modified fork of payhere_mobilesdk_flutter Package 2: flutter_payhere_platform_interface and Package 3: flutter_payhere_web

  2. test multiplatform_example from https://github.com/iwalpola/flutter_payhere_packages on android, iOS and web

  3. update README.md, pubspec.yaml and CHANGELOG.md in

in the pubspecs, the dependencies are linking to my repo so change those and then change homepage and publish_to properties

  1. final folder search to make sure that the word "iwalpola" does not appear in any publishable files
  2. if you are satisfied, publish on pub dev
PayHereDevs commented 3 years ago

Hello @iwalpola, apologies for not getting back to you soon.

Thank you for this amazing pull request. Our team has done some checking to see if we can directly merge it. We noticed that you have used the PayHere JavaScript Library for the Web integration.

The code interface for the JavaScript SDK is similar to that of the existing Dart code interface but there is one issue that we need to resolve before we merge these changes.

We will have an internal discussion to see if the Payment ID can be returned as well.

Further, since this is a major structural change to the SDK we will most likely release the first few versions as alpha updates in a separate branch.

We will keep you updated going forward. Once again, we highly appreciate contributions and value generated from individuals like you.

iwalpola commented 3 years ago

Thanks for the nice comment guys. Glad to help.

ShanArosh commented 5 months ago

Any Advancements ??