Comments on the README - Githubissues

PayMaya / PayMaya-Node-SDK

MIT License

18 stars 10 forks source link

Comments on the README #1

Open jgfrancisco opened 8 years ago

jgfrancisco commented 8 years ago

On 3. Execute Checkout API
- typo on comment for itemAmountDetailsOptions
On Retrieve Checkout
- What will happen if I create 2 checkout (call checkout.execute(callback) twice). Which one will be retrieved by: checkout.retrieve(callback)
Why is there a Payments header?
On the customization example
- maybe use dummy example for the logo and icon URLs

haroldcalayan commented 8 years ago

Hi @jgfrancisco,

Thanks for your evaluation. These are my actions in your concerns:

On 3. Execute Checkout API: I just put the comment "Construct item here" in the correct position.
On Retrieve Checkout - What will happen if I create 2 checkout (call checkout.execute(callback) twice). Which one will be retrieved by: checkout.retrieve(callback): You will get the checkout object of the last id that you get after execute.
Why is there a Payments header?: I just removed this.
On the customization example, maybe use dummy example for the logo and icon URLs: I put dummies now.

If you have time, you can review again those items. Thanks!

jgfrancisco commented 8 years ago

Hi @haroldcalayan,

Customizations still show:

customization.iconUrl = "https://cdn.paymaya.com/production/checkout_api/customization_example/youricon.ico";
customization.appleTouchIconUrl = "https://cdn.paymaya.com/production/checkout_api/customization_example/youricon_ios.ico";
customization.customTitle = "Checkout Page Title";
customization.colorScheme = "#368d5c";

maybe align with other examples and use cdn.someserver.com instead