search

PayU / openapi-validator-middleware

Input validation using Swagger (Open API) and ajv
Apache License 2.0
144 stars 50 forks source link

Add CircleCI configuration #133

Closed kibertoad closed 4 years ago

kibertoad commented 4 years ago

Travis is acting up again, so here's alternative CI solution that should be faster and more stable. After this is merged, we need to enable it from CircleCI panel.

kibertoad commented 4 years ago

@kobik Addressed the comments, also bumped api-schema-builder version as requested elsewhere

kibertoad commented 4 years ago

@kobik From my understanding, failing coveralls is not a problem on our side: https://github.com/lemurheavy/coveralls-public/issues/632

Unless CircleCI requires some additional configuration that Travis does not, but I doubt that. Hopefully it'll resolve itself.

kobik commented 4 years ago

@kobik From my understanding, failing coveralls is not a problem on our side: lemurheavy/coveralls-public#632

Unless CircleCI requires some additional configuration that Travis does not, but I doubt that. Hopefully it'll resolve itself.

@kibertoad you can remove that as we already have coveralls as one of our checks

kibertoad commented 4 years ago

@kobik Done! Should I add same configuration to schema-builder and contract-validator as well?

kibertoad commented 4 years ago

@kobik Do we want to keep Travis for the time being or just CircleCI is good enough?

kobik commented 4 years ago

@kobik Done! Should I add same configuration to schema-builder and contract-validator as well?

@kibertoad, that would be awesome!

@kobik Do we want to keep Travis for the time being or just CircleCI is good enough?

do you think we should?

IMO, there is no need for that.

kibertoad commented 4 years ago

@kobik Done!

kobik commented 4 years ago

@kibertoad for some reason coveralls check isn't done. but we can merge it for now as there is a check also in tests.