PayU / openapi-validator-middleware

Input validation using Swagger (Open API) and ajv
Apache License 2.0
144 stars 50 forks source link

Added more customisation for Fastify skipList #153

Closed ozonep closed 1 year ago

ozonep commented 3 years ago

So we can only skip specific requests (GET/POST/etc.) for specific routes.

kibertoad commented 3 years ago

@ozonep Could you please add tests for this?

kibertoad commented 3 years ago

@kobik Something appears to be wrong, CircleCI is not returning status, wonder if we need to tweak something on CircleCI panel side. Could you please either take a look or give me admin permissions for the repo so that I could take a look? Alternatively I could add GitHub actions CI instead, that one works with zero additional setup, as opposed to Travis and CircleCI.

ozonep commented 3 years ago

Will add tests now.

kobik commented 3 years ago

@kobik Something appears to be wrong, CircleCI is not returning status, wonder if we need to tweak something on CircleCI panel side. Could you please either take a look or give me admin permissions for the repo so that I could take a look? Alternatively I could add GitHub actions CI instead, that one works with zero additional setup, as opposed to Travis and CircleCI.

will check that

kobik commented 3 years ago

@ozonep seems to be ok now

kibertoad commented 3 years ago

@ozonep Linting is failing, could you please fix the error?

ozonep commented 3 years ago

Docs updated!

kibertoad commented 3 years ago

@kobik This will be a semver major. Are we ready to release that already, or you'd prefer to keep current major going for a while?

kobik commented 3 years ago

@kibertoad I haven't reviewed the changes, so I can't tell by myself. can't we make it somehow backwards compatible?

kibertoad commented 3 years ago

@kobik We could if you strongly prefer keeping it backwards-compatible, but that would add more conditional branching, make code more heavyweight and less performant, and would expose worse API to the end user, so I would vote against it. It only affects fastify users and only those who use skiplist, though.

kobik commented 3 years ago

@kibertoad , so a major it is.

we need to add the breaking changes note in the changelog file and upgrade procedure from the previous version

kobik commented 3 years ago

@kibertoad i'd really like to this breaking change to be shipped with other breaking changes such as upgrading to ajv@8 in api-schema-build.