search

PayU / openapi-validator-middleware

Input validation using Swagger (Open API) and ajv
Apache License 2.0
144 stars 50 forks source link

Make init function synchronous #69

Closed kibertoad closed 5 years ago

kibertoad commented 5 years ago

fixes #38

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.008%) to 99.115% when pulling f5d3558f06fb88bf9128414e51ddfcdd893c4d75 on feature/38-sync-init into 98d0f169fed2b15a9d7dc5ab45cb2eaf036c0388 on master.

kibertoad commented 5 years ago

@kobik Resolved conflicts in readme.

kibertoad commented 5 years ago

@kobik Is anything still remaining for this one?

kobik commented 5 years ago

@kibertoad, I'd like to all issues in https://github.com/Zooz/express-ajv-swagger-validation/milestone/1 to be handled for 1.0.0 release, as all of them are breaking changes. so lets hold this back, until the two other issues are handled.

kibertoad commented 5 years ago

https://github.com/Zooz/express-ajv-swagger-validation/issues/36 doesn't look breaking to me, it would be an optional parameter; if nothing is passed, it would work exactly the way it does now. https://github.com/Zooz/express-ajv-swagger-validation/issues/58 is not an implementation thing altogether, express-ajv-swagger-validation 1.0.0 could keep existing after renamed package is published.

kibertoad commented 5 years ago

@kobik Can we merge this?

kobik commented 5 years ago

@idanto do you have any objection against applying this breaking change at this time?

kibertoad commented 5 years ago

@kobik Something broke down on snyk patch end, it seems. Maybe we need to reapply it?

lirantal commented 5 years ago

@kibertoad @idanto looking into it as a first workaround can you please remove the .snyk policy file from the project? this should fix up the CI

kibertoad commented 5 years ago

@lirantal Yeah, opened https://github.com/Zooz/express-ajv-swagger-validation/pull/79 for it. Since fixed Lodash is out, shouldn't be necessary anymore, npm is not reporting any warnings locally for me anymore.

kibertoad commented 5 years ago

But https://github.com/Zooz/api-schema-builder/pull/27#issuecomment-510113470 could still be merged to be on a safe side.

lirantal commented 5 years ago

@kibertoad great so let's merge that PR, then rebase this with master and then this CI should pass.

kibertoad commented 5 years ago

@idanto What is remaining before this can be merged?