search

PayU / prometheus-api-metrics

API and process monitoring with Prometheus for Node.js micro-service
Apache License 2.0
130 stars 44 forks source link

Support for prom-client v13 #65

Closed yorch closed 3 years ago

yorch commented 3 years ago
yorch commented 3 years ago

Fixes #64, #61 and #63

yorch commented 3 years ago

@kobik gently reminder :) would be great to merge this, thanks!

yorch commented 3 years ago

@kobik sure.. done!

kobik commented 3 years ago

@kobik sure.. done!

thanks @yorch

yorch commented 3 years ago

@kobik thanks for the approval, unfortunately I cannot merge this as I don't have privileges.

kobik commented 3 years ago

@yorch is like to merge and release both this and custom labels together, that's why I didn't merge it yet

yorch commented 3 years ago

@kobik still not sure I follow, eventually you will have to merge one of these first and then the other. Most likely, one of these is gonna cause conflicts with the other that wont bubble up until one of these is merged

kobik commented 3 years ago

@yorch , i've made some tests on my end and the current version works with both prom-client 12 and 13, so i think we can bump it by a minor version.

what do you think?

do you see a real reason for bumping a major version?

yorch commented 3 years ago

@kobik agree, since there are not actual break changes then if it still works with 12, makes sense to keep the update as a minor version 👍