search

PaystackHQ / paystack-android

Paystack SDK for Android. Accept payments on Android
Apache License 2.0
126 stars 101 forks source link

New SDK Update has no clear changelog and SDK breaks the application. #15

Closed stonekase closed 7 years ago

stonekase commented 7 years ago

Problem/Motivation

(Why the issue was filed, steps to reproduce the problem, etc.)

Proposed resolution

(Description of the proposed solution, the rationale behind it, and workarounds for people who cannot use the patch.)

Transaction Class was moved out of a whole namespace and was not stated in the Changelog.Its really sad.

ibrahimlawal commented 7 years ago

Good morning,

We will update the changelog later today. The update is a major release and will break createToken-dependent apps. As for chargeCard dependent ones, only the signature of the onError method has changed to allow a transaction object.

-----Original Message----- From: "Tim Mividi" notifications@github.com Sent: ‎4/‎13/‎2017 1:35 AM To: "PaystackHQ/paystack-android" paystack-android@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Subject: [PaystackHQ/paystack-android] New SDK Update has no clear changelogand SDK breaks the application. (#15)

Problem/Motivation (Why the issue was filed, steps to reproduce the problem, etc.) Proposed resolution (Description of the proposed solution, the rationale behind it, and workarounds for people who cannot use the patch.) Repeatable Always|Sometimes|Specific conditions|Specific times (If it is a bug, you are reporting lease specify:) Steps to repeat: (Describe how the issue can be repeated by someone who is to work on it) Step 1 Step 2 ... Expected Results: (What you expected steps 1, 2 and 3 to give) Actual Results: (What is gave including any error messages, memory dump etc that can help) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ibrahimlawal commented 7 years ago

Hello @stonekase,

Did the response above help you ensure compatibility?

stonekase commented 7 years ago

Apologies for the late response.As usual ,i have already fixed it before raising the issue.It was more of a pointer for others to note.