PaystackHQ / paystack-android

Paystack SDK for Android. Accept payments on Android
Apache License 2.0
126 stars 102 forks source link

Is there any way to customize PinActivity and OtpActivity? #40

Closed borichellow closed 4 years ago

borichellow commented 6 years ago

it's not an issue, but question.

Case: when user add new card in our app, PaystackSdk request for pin/OTP (PinActivity/OtpActivity is run). Obvious this inner activities are not in our app style. Is there any way to change it's layouts?

ibrahimlawal commented 6 years ago

No way yet.

However we are open to a PR that helps us expose the possibility to use a custom Activity to get the values.

borichellow commented 6 years ago

@ibrahimlawal can you provide some example, or docs how to do it?

ibrahimlawal commented 6 years ago

It can't be done yet.

mikelis135 commented 6 years ago

How about you make your dialog finer, or give the ability to extend the style to tweak a few things of your inner activity.

mikelis135 commented 6 years ago

You can give us access to parse say, our primary color, which you can use for the paystack dialog header background, instead of the static black, or create an interface we can implement to access your UI and teak thanks.

stonekase commented 6 years ago

this response might come late but the way I did mine was to use the GitHub source code and I changed the activity the pin/otp activity is called. with the source code you can pretty much do anything. for example you can hold off processing until verification timeout window to auto-verify etc etc.I did this over a year ago and it still works with the sdk. Kindly note your android programming skill has to be strong to execute.

stonekase commented 6 years ago

No way yet.

However we are open to a PR that helps us expose the possibility to use a custom Activity to get the values.

I did this over 1 year ago, with the source code one can pretty much do anything.the only thing is the person will have to manually update changes to the sdk if there is ever any breaking changes.so far so good my implementation still works.....

mikelis135 commented 6 years ago

Yes, I have the source code. Last time I edited it, I broke it. I'll take my time to edit it and give it a cleaner design and make sure it's working

stonekase commented 6 years ago

@ibrahimlawal can you provide some example, or docs how to do it?

screen shot 2018-09-19 at 7 35 51 pm
stonekase commented 6 years ago

Yes, I have the source code. Last time I edited it, I broke it. I'll take my time to edit it and give it a cleaner design and make sure it's working

I just added some images to help show u the classes to modify.my implementation still works from late 2015

screen shot 2018-09-19 at 7 34 40 pm
mikelis135 commented 6 years ago

Cool, thanks