zaheer-dvt commented 1 year ago

Changes:

Modified ErrorView to make the button optional and also added an optional error which causes the view to be closed automatically and passes the error back to the developer
Added a fatalError status to ChargeCardState to be used for errors that cannot be recovered from and return an error to the developer
Added a mapping in ChargeCardView to use the new ErrorView functionality for the fatalError state
Created TransactionError, a public enum that returns predefined error cases to the developer when the payment reaches an error state like this scenario.
Changed the error type in TransactionResult to the above
Added unit tests

github-actions[bot] commented 1 year ago

	Warnings
:warning:	Sources/PaystackUI/Charge/ChargeCard/Container/ChargeCardViewModel.swift#L63 - TODOs should be resolved (Add logic for pending state). (`todo`)
:warning:	Sources/PaystackUI/Charge/ChargeCard/Container/ChargeCardViewModel.swift#L66 - TODOs should be resolved (Add logic for 3DS). (`todo`)
:warning:	Sources/PaystackUI/Charge/ChargeView.swift#L32 - TODOs should be resolved (Update once we have new design...). (`todo`)
:warning:	Tests/PaystackSDKTests/UI/Charge/ChargeCard/ChargeCardViewModelTests.swift#L192 - Function should have complexity 10 or less: currently complexity equals 11 (`cyclomatic_complexity`)