zaheer-dvt commented 1 year ago

Changes:

Updated VerifyAccessCode to be passed in a reference that comes from its original model
Created ChargeCompletionDetails, a container for details we want to pass on a completed result which currently only hold the reference
Updated TransactionResult to include arguments for error and completed (above)
Updated the success state in ChargeState to include the ChargeCompletionDetails, and then pass it through to ChargeSuccessView to be eventually returned
Also created ChargeErrorDetails to follow a similar process with ErrorView
Updated unit tests to account for the changes

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

No Coverage information
0.0% Duplication

github-actions[bot] commented 1 year ago

	Warnings
:warning:	Sources/PaystackUI/Charge/ChargeView.swift#L32 - TODOs should be resolved (Update once we have new design...). (`todo`)
:warning:	Sources/PaystackUI/Charge/ChargeViewModel.swift#L39 - TODOs should be resolved (Display a fatal error here in ...). (`todo`)
:warning:	Sources/PaystackUI/Charge/Models/ChargeState.swift#L3 - TODOs should be resolved (Add state for select payment c...). (`todo`)
:warning:	Tests/PaystackSDKTests/UI/Charge/ChargeCard/ChargeCardViewModelTests.swift#L4 - Type body should span 200 lines or less excluding comments and whitespace: currently spans 202 lines (`type_body_length`)
:warning:	Tests/PaystackSDKTests/UI/Charge/ChargeCard/ChargeCardViewModelTests.swift#L265 - Function should have complexity 10 or less: currently complexity equals 12 (`cyclomatic_complexity`)
:warning:	Tests/PaystackSDKTests/UI/Charge/ChargeViewModelTests.swift#L97 - Line should be 120 characters or less: currently 145 characters (`line_length`)

Generated by :no_entry_sign: Danger Swift against 976962f0fc187ec53ea3c3d93d151904d933490b

PaystackHQ / paystack-sdk-ios