Payum / PayumBundle

Payum offers everything you need to work with payments. From simplest use cases to very advanced ones.
https://payum.forma-pro.com/
MIT License
565 stars 143 forks source link

feat: php 7.4 features and typehints #537

Closed Chris53897 closed 2 years ago

Chris53897 commented 2 years ago

Add php 7.4 features. Add typehints Remove wrong (According to PhpStorm) and useless DocBlocks Comments

DI for Payum (container->get() is deprecated and removed in Symfony 6). This needs to be tested. But tests do not work correct. Payum\Core\Payum vs Payum\Core\Registry\RegistryInterface in Commands? See old DocBlock return hints. So this should be merged upfront https://github.com/Payum/PayumBundle/pull/536

Chris53897 commented 2 years ago

Can you pleasse check if all BC Breaks are removed now? Tests look good now.

pierredup commented 2 years ago

Thank you @Chris53897