feat: add typehints for factories

Payum / PayumBundle

Payum offers everything you need to work with payments. From simplest use cases to very advanced ones.

https://payum.gitbook.io/payum

MIT License

569 stars 142 forks source link

Closed Chris53897 closed 2 years ago

Chris53897 commented 2 years ago

Needs review and testing. See https://github.com/Payum/PayumBundle/pull/536 Could be BC Break if User extend these factories. The interface is not changed.

Can someone explain the background why in the Interface the ReturnTypes are not set, and $modelClass is not TypeHinted with string in the past?

Chris53897 commented 2 years ago

Thanks for the explanation. Since there are no conflicts with master i did an empty commit to trigger GitHub actions again. Tests are green now.

pierredup commented 2 years ago

Thank you @Chris53897