feat: merge symfony bridge (symfony 7)

Payum / PayumBundle

Payum offers everything you need to work with payments. From simplest use cases to very advanced ones.

https://payum.gitbook.io/payum

MIT License

569 stars 142 forks source link

feat: merge symfony bridge (symfony 7) #560

Closed Chris53897 closed 5 months ago

Chris53897 commented 6 months ago

Based on https://github.com/Payum/PayumBundle/pull/557

I did the following changes:

fixed the namespace for the tests-files.
add support for "symfony/dependency-injection" 7
integrated the trait in interface in the repo. Like Drupal did. https://www.drupal.org/project/drupal/issues/3397522

Chris53897 commented 6 months ago

I did a test in a real life project and payment worked got us.

pierredup commented 6 months ago

Thanks @Chris53897

fixed the namespace for the tests-files

I added this change to #557. It's better to have all related changes in the same PR

integrated the trait in interface in the repo

I wonder if it's even worth it to support the setContainer calls with a custom interface and trait. Since there are only 3 internal classes that uses this, it might be better to just inject the container into the constructor of the classes directly and get rid of the interface and trait completely.

Chris53897 commented 6 months ago

I am fine to get rid of them. I do not know how to implement it. My main goal is to move towards symfony 7 support. I archived this now (with a copy of this branch).

pierredup commented 6 months ago

I have pushed a change to remove the ContainerAwareInterface and ContainerAwareTrait

Chris53897 commented 5 months ago

Thanks. Is there something needed from my side to get it merged?