search

Payum / PayumBundle

Payum offers everything you need to work with payments. From simplest use cases to very advanced ones.
https://payum.gitbook.io/payum
MIT License
569 stars 142 forks source link

L_PAYMENTREQUEST_0_ITEMCATEGORYn #6

Closed rat4m3n closed 11 years ago

rat4m3n commented 11 years ago

Hi there,

Just a quick one... Do we have any handler for 'L_PAYMENTREQUEST_0_ITEMCATEGORYn' ?

I am happy to add this if we don't just wonder if I am not simply missing it.

makasim commented 11 years ago

there some L_PAYMENTREQUEST_XXX fields added (see here https://github.com/Payum/PaypalExpressCheckoutNvp/blob/master/src/Payum/Paypal/ExpressCheckout/Nvp/PaymentInstruction.php#L153) but not this one? What this field is used for?

rat4m3n commented 11 years ago

This is to set category for the item:

Paypal docs:

Make sure L_PAYMENTREQUEST_0_ITEMCATEGORY is set to "Digital" for every item in the DoExpressCheckoutPayment request as well as SetExpressCheckout. Failing to do so will result in incorrect fee calculations.

So we would need a setter setLPaymentrequestCategory or something for this and add this property to be sent to paypal to handle those i guess...

rat4m3n commented 11 years ago

Having full instruction constructed I have noticed 2 more:

    // Set REQCONFIRMSHIPPING to 0
    // Set NOSHIPPING to 1

Those don't seem to be mandatory but can be set for Digital Express Checkout Method.

Once we have them added we state 'Digital Goods - Express Checkout' compatibility in docs.

makasim commented 11 years ago

close in favor #7