search

Payum / PayumYiiExtension

Rich payment solutions for Yii framework. Paypal, payex, authorize.net, be2bill, omnipay, recurring paymens, instant notifications and many more
https://payum.forma-pro.com/
MIT License
12 stars 16 forks source link

Fix Payments handler not handling redirects #13

Closed alexandernst closed 10 years ago

alexandernst commented 10 years ago

I'm not sure if lines 19-21 are necessary or not. What do you think?

alexandernst commented 10 years ago

@makasim Just pushed latest changes. Now I handle all Exceptions via class method (the good way).

alexandernst commented 10 years ago

@makasim Sorry, my comment got lost in the outdated diffs. I'm copying it here:

What do you mean by "move it to the extension"? Isn't this file part of the extension?

makasim commented 10 years ago

@alexandernst Sorry, I meant to move the logic to the component class. Right now it is in the controller

alexandernst commented 10 years ago

@makasim Ah, I see. I'm not sure if I can redirect from the Component because it extends from CApplicationComponent. Do you know how can I redirect from there?

makasim commented 10 years ago

no, I dont know. Let's keep it as is,

alexandernst commented 10 years ago

Great! Is there anything else left on this or we can merge?

makasim commented 10 years ago

thanks