search

Payum / iso4217

ISO 4217 PHP Library
MIT License
162 stars 7 forks source link

Add tests to `.gitattributes` #13

Closed jdreesen closed 2 years ago

jdreesen commented 2 years ago

Currently, composer warns about the test files not complying to PSR-4:

Class Payum\ISO4217\Tests\CurrencyTest located in ./vendor/payum/iso4217/CurrencyTest.php does not comply with psr-4 autoloading standard. Skipping.
Class Payum\ISO4217\Tests\ISO4217Test located in ./vendor/payum/iso4217/ISO4217Test.php does not comply with psr-4 autoloading standard. Skipping.

As those files are not needed when installing the package, I added them to .gitattributes which fixes the warning.

pierredup commented 2 years ago

@jdreesen Thanks for the PR, but this package has been deprecated (#11), and already removed from payum/core (payum/core#879), so you should not rely on this package anymore, or upgrade the version of Payum you are using which should get rid of the error.

jdreesen commented 2 years ago

As this package is still present in Payum's composer.json (here you say it'll get removed in v2), composer adds it to the autoloading and thus the warning is still there.

So it seems the only way to get rid of the warning before Payum v2 is released would be to merge this and release a new version of payum/iso4217.

pierredup commented 2 years ago

Thanks @jdreesen