PazerOP / tf2_bot_detector

Automatically detects and votekicks cheaters/bots in TF2 casual.
MIT License
403 stars 54 forks source link

Add the option to disable the offical player list. #314

Open andy013 opened 3 years ago

andy013 commented 3 years ago

Add an easy option to disable the official player list and just use your own personal list. Some people don't want to trust someone else to mark players. I think you can do this currently with an empty file but having it as an easy tick option in the tool would be very helpful.

I think this would build trust in the tool and help to increase adoption amongst certain players.

2l47 commented 3 years ago

This would also make testing easier by enabling the isolation of marking to a specific list.

2l47 commented 3 years ago

In my experience, deleting the official lists led to them being recreated. If using an empty file doesn't work (I didn't try that), you can replace them with "dummy" lists like these: https://milenko.ml/playerlist.official.json https://milenko.ml/rules.official.json

Kenajcrap commented 3 years ago

This would also make testing easier by enabling the isolation of marking to a specific list.

the tool already says which lists are marking a player if you hover over the marked player in the playerlist or check the tool's logs.

In my experience, deleting the official lists led to them being recreated. If using an empty file doesn't work (I didn't try that), you can replace them with "dummy" lists like these: https://milenko.ml/playerlist.official.json https://milenko.ml/rules.official.json

Leaving the file blank will suffice, since the examples you mentioned include the line "update_url" that means that the owner of that domain can update the files at any moment to include steamids (just like the official or third party lists do). This is expected behavour, but not if your objective is to create a dummy file that does nothing

I would like there to be a way to easily disable the default list just because this would lead to more trust in the tool's intentions from players

2l47 commented 3 years ago

the tool already says which lists are marking a player if you hover over the marked player in the playerlist or check the tool's logs.

Yes, but list creators as well as users might benefit from only seeing players marked by their lists, for the sake of testing or otherwise. e.g. while making a new rule, seeing a new mark show up clearly is important.

since the examples you mentioned include the line "update_url" that means that the owner of that domain can update the files at any moment to include steamids (just like the official or third party lists do). This is expected behavour, but not if your objective is to create a dummy file that does nothing

Thanks for pointing that out, I just removed it.

ClusterConsultant commented 3 years ago

The playerlist is still showing as having an update url. Also they don't even need to have contents. They could literally just be blank.

Also as a rules contributor, I've never had issues testing a rule with all playerlists I usually use present. The program is also pretty verbose when someone is marked. I'm not saying the usecase is nonexistent, just seems like a weird angle.

I'll probably make a guide for this or include an option in the installer rewrite (the odds increase the more different people ask about this) but the best solution remains with the umbrella idea of in application playerlist management. See #251

2l47 commented 3 years ago

The playerlist is still showing as having an update url.

Refresh/clear cache? I don’t see one.

Tiagoquix commented 2 years ago

Make the file empty and try marking it as read-only.