search

PazerOP / tf2_bot_detector

Automatically detects and votekicks cheaters/bots in TF2 casual.
MIT License
400 stars 55 forks source link

Change UI to correctly represent Steam ID3 and not Steam ID #326

Closed Koi-TF2 closed 2 years ago

Koi-TF2 commented 3 years ago

TF2's "status" command uses Steam ID3, not Steam ID.

"Steam ID" is in the format STEAM_X:X:XXXXXXXX. TF2BD utilizes TF2's built in "status" command which is in the format of "Steam ID3" [U:X:XXXXXXXXX]. Both of these ID types contain completely different strings of numbers and are formatted differently. This pull request is a simple, small UI change to differentiate between ID and ID3 within the main UI windows.

I can understand, for simplicity sake, why it would be easier to just say "ID" rather than "ID3", but I figured it might be worth bringing up anyway...

PazerOP commented 3 years ago

I realize that it is more technically correct, however I am slightly concerned about user confusion as far as input fields go:

I feel like it might be better to just update my steam id parsing so that it can handle the other formats (i think it currently handles id3 and id64 only).

With the labels, I don't think any of these questions apply. I feel like it's probably all right to be specific about saying "Steam ID3" in that case.