PazerOP / tf2_bot_detector

Automatically detects and votekicks cheaters/bots in TF2 casual.
MIT License
403 stars 54 forks source link

[BUG] Program is unable to find important command-line parameters #331

Closed UAVXP closed 3 years ago

UAVXP commented 3 years ago

Describe the bug After the latest TF2 update, which has been released on 22'nd of June, 2021, TF2 Bot Detector cannot properly connect with the game

To Reproduce

  1. Update TF2 after 22'nd of June, 2021
  2. Run Bot Detector
  3. Press "Launch TF2"
  4. See error

Expected behavior Runned TF2

Logs No significant log errors found

Screenshots image

Desktop

Additional context Before the latest TF2 update everything was working fine

jmke79 commented 3 years ago

able to replicate on Windows 10 also; exact same issue

Spygineer2 commented 3 years ago

I am having the same issue

Susorodni commented 3 years ago

With the recent update, also having the same issue

Koi-TF2 commented 3 years ago

This BD issue is caused by the RCE exploit fix previously implemented in CS:GO being brought over to TF2. In doing so, the steam://run argument functionality has changed due to API changes.

Temporary fix:

Now you can launch TF2BD normally using its Launch TF2 button since it will be able to find the arguments it needs to run.

PazerOP commented 3 years ago

I've been very busy lately, which is why there hasn't been any activity lately. I'll try to implement a fix this evening.

Regarding the workaround above, you shouldn't need to close steam and edit the config. I think you can just modify command line options via the steam GUI by right clicking on tf2 and hitting settings or properties or whatever.

Koi-TF2 commented 3 years ago

Regarding the workaround above, you shouldn't need to close steam and edit the config. I think you can just modify command line options via the steam GUI by right clicking on tf2 and hitting settings or properties or whatever.

Pazer, I do not recommend doing this because the launch options are too long. There is a visual bug within the steam interface which cuts the launch options short. Technically they are still present and will still work, but they are not visible or modifiable beyond a certain point, so do this at your own risk. It likely won't cause any serious issue but just know that it's a problem

KaineWooten commented 3 years ago

Wouldn't a work around be to create a batch file with the said command line paramaters to open the application. You'd just need to similarly set the launch options to be similar to what was presented already but with the batch file.

Jesseman1 commented 3 years ago

crap, I just realized I probably should have just commented here instead of posting a whole new issue about it. But yeah, I don't know if I can follow Koi's guide cuz those fields are not in my file...

Koi-TF2 commented 3 years ago

those fields are not in my file...

Assuming you are in the right file (localconfig.vdf), then the reason your 440 doesn't have a "LaunchOptions" field is because you have never set advanced launch options ever before. Either you can manually add the field yourself, or the easier method would just be to add one adv launch option via the built in menu in steam. Doing so should cause the field to be generated. I hope this helps

Jesseman1 commented 3 years ago

Assuming you are in the right file (localconfig.vdf), then the reason your 440 doesn't have a "LaunchOptions" field is because you have never set advanced launch options ever before. Either you can manually add the field yourself, or the easier method would just be to add one adv launch option via the built in menu in steam. Doing so should cause the field to be generated. I hope this helps

I have advanced launch options already in place from using mastercoms' comfig. So I don't know why the field is not already there, unless there is some other launch options box that I don't know about.

Koi-TF2 commented 3 years ago

I have advanced launch options already in place from using mastercoms' comfig. So I don't know why the field is not already there, unless there is some other launch options box that I don't know about.

Advanced launch options are normally placed in the following location: In steam, right click on TF2 in your library, then click on properties. In the General tab, there will be a section labeled "Launch Options". The reason I do not advise just copy+pasting the full string of TF2BD's launch options into that location is what I described above:

Pazer, I do not recommend doing this because the launch options are too long. There is a visual bug within the steam interface which cuts the launch options short. Technically they are still present and will still work, but they are not visible or modifiable beyond a certain point, so do this at your own risk. It likely won't cause any serious issue but just know that it's a problem

Jesseman1 commented 3 years ago

yes, I already have some inputs there for the comfig

Koi-TF2 commented 3 years ago

yes, I already have some inputs there for the comfig

If this is the case, and you are sure you still don't have any LaunchOptions field inside the localconfig.vdf file for TF2, then I am not sure. Perhaps this is caused by steam cloud sync not syncing it correctly? You can either manually add the field to the file as mentioned before, or alternatively you can try the other method by copy+pasting the full args directly into the launch options area inside the steam interface. Just be aware that they will NOT all show up in the steam interface - some will be invisible because the arguments are too long. Still worth a try though