PazerOP / tf2_bot_detector

Automatically detects and votekicks cheaters/bots in TF2 casual.
MIT License
403 stars 54 forks source link

[BUG] Detector crashing on server ddos attacks? #367

Open Jesseman1 opened 2 years ago

Jesseman1 commented 2 years ago

Describe the bug

BotDetector crashed during a game with a lag-inducing cheater.

To Reproduce

I'm unsure how they managed to do this, but while the server was being ddosed, the bot detector crashed and was unable to call votes or post chat warning after turning it back on.

Expected behavior

The bot detector to continue working during ddos attacks on the server.

Logs 2021-09-13_22-32-56.log 2021-09-13_22-50-30.log 2021-09-13_23-51-05.log

Screenshots

No screenshot available

Desktop (please complete the following information):

  • OS: Windows 10
  • Version of bot detector: 1.2.1.934

Additional context Cheater that was in the game seemed smugly aware that the detector had crashed before I realized anything, it's how I figured out to tab out and look at it.

ClusterConsultant commented 2 years ago

That does not appear to be a crash. The most likely explanation would be that a network afflicted server does not show users as properly connected. TF2BD doesn't call votes if people are not in the server since joining users would not see the vote once they fully load in.

Providing the user an option to configure TF2BD to call impossible votes would probably be the best solution here.

Jesseman1 commented 2 years ago

the bot detector was completely closed when i checked on it, it was running when i launched the game

ClusterConsultant commented 2 years ago

The logs you show a graceful shutdown. Either these aren't the right ones or something very unusual is happening.

Jesseman1 commented 2 years ago

2021-09-13_00-42-21.log 2021-09-13_22-32-56.log 2021-09-13_22-50-30.log 2021-09-13_23-51-05.log ok why does dragging keep leaving one file out? 2021-09-14_01-16-32.log

ClusterConsultant commented 2 years ago

2021-09-14_01-16-32.log shows a non-graceful shutdown. If looks to be related to rcon failures. Beyond that, without more reports from other users it is difficult to determine a causation.

This has been noted, and there may be follow up questions from others, but for now this is probably dead in the water.