search

PazerOP / tf2_bot_detector

Automatically detects and votekicks cheaters/bots in TF2 casual.
MIT License
404 stars 56 forks source link

Split long chat messages #381

Open ecawthorne opened 2 years ago

ecawthorne commented 2 years ago

Describe the bug

When multiple cheaters are on the opposite team the chat message "Attention! There are n cheaters on the other team named x, x. Please kick them!" does not always list all cheaters. Very minor bug bug can be annoying if playing against human cheaters.

To Reproduce

Steps to reproduce the behavior:

  1. Join game with two or more cheaters
  2. Chat message output is "Attention! There are 3 cheaters on the other team named First Cheater, Second Cheater. Please kick them!"

Expected behavior

Matching number of cheaters and number of names listed or separate message that is more grammatically correct if all names cannot fit in the message.

Logs

[17:32:51] ModeratorLogic.cpp(454):HandleConnectedEnemyCheaters: Telling the other team about 2 cheater(s) named 
    [U:1:XXXXXXXXX] (marked in "cfg/playerlist.json")
    [U:1:XXXXXXXXX] (marked in "cfg/playerlist.json")
[17:32:52] WorldState.cpp(681):OnConsoleLineParsed: Chat message from [U:1:XXXXXXXXX]: "Attention! There are 2 cheaters on the other team named (27 character length name). Please kick them!"
[17:21:38] ModeratorLogic.cpp(454):HandleConnectedEnemyCheaters: Telling the other team about 3 cheater(s) named 
    [U:1:XXXXXXXXX] (marked in "cfg/playerlist.json")
    [U:1:XXXXXXXXX] (marked in "cfg/playerlist.json")
    [U:1:XXXXXXXXX] (marked in "cfg/playerlist.json")
[17:21:38] WorldState.cpp(681):OnConsoleLineParsed: Chat message from [U:1:XXXXXXXXX]: "Attention! There are 3 cheaters on the other team named (10 character length name), (27 character length name). Please kick them!"

The unlisted player's name in both instances was 22 characters long.

Desktop (please complete the following information):

  • OS: Windows 10
  • TF2 Bot Detector v1.2.1.934

Additional context

Apologies for anonymizing names and SteamIDs, but I don't want my steam account associated with my GitHub account. These players were also manually marked by me so even though I know they are hacking I don't want them to be able to use this issue as a way to discredit your tool. Additionally, I'd like to say thank you for creating and maintaining this tool. It's been a huge help in increasing the quality of matches since I discovered it.

ClusterConsultant commented 2 years ago

There is a hard cap on how long messages can be, as I am sure you are aware. Multiple messages seems unnecessary from a design perspective since only one vote can be called at a time anyways. I could see this being an option, but this is most certainly not a bug.

ecawthorne commented 2 years ago

Thanks for the clarification. This is the first time I've submitted an issue so I wasn't sure how to classify it.