search

PazerOP / tf2_bot_detector

Automatically detects and votekicks cheaters/bots in TF2 casual.
MIT License
404 stars 56 forks source link

Remove "[english]" and "GameUI_vote_failed_vote_in_progress" strings in closecaption_ files #390

Open Tiagoquix opened 2 years ago

Tiagoquix commented 2 years ago

They are useless and make no difference. The proof of this is that you can open the file tf_brazilian.txt, tf_german.txt, tf_ukrainian.txt etc. and you will see that none of them have "[english]" strings.

These strings were probably used for some checking purpose in the past, but the translation file formats have changed recently and "[english]" has been removed from the files.

In short: the presence of the "[english]" strings is not necessary for the custom files to work.

Tiagoquix commented 2 years ago

I would also like to point out that I do not think the change to GameUI_vote_failed_vote_in_progress in the closecaption_ files is necessary, since basically it only defines the string to be displayed on the panel when the vote fails, but the vote eraser addon ends up hiding everything in the panel.

As a reference, the string "GameUI_vote_failed" "Vote Failed" also appears in the same panel as GameUI_vote_failed_vote_in_progress, but it is not changed by the closecaption_ files.