search

Pe8er / Sidebar.Widget

28 stars 7 forks source link

Disable widget command execution if widgets are `disabled` #13

Closed jakobwesthoff closed 7 years ago

jakobwesthoff commented 7 years ago

This PR disables the execution of the commands belonging to the widgets if their options.widgetEnabled property is set to false.

Furthermore I moved the check in the update methods for disabled widgets into a guard clause for better readability

jakobwesthoff commented 7 years ago

I added a commit, which fixes the misuse of the (in coffee script non existent) ternary operator

jakobwesthoff commented 7 years ago

After further testing I realized, that this does not seem to work. Not 100% sure why yet. I need to investigate further. Until then I am closing this PR.