search

PeARSearch / PeARS-federated

This is the version of PeARS for use in a federated context: admins create PeARS instances that users can join to contribute to the index.
Other
17 stars 6 forks source link

22 translations #31

Open serpico opened 3 months ago

serpico commented 3 months ago

If I may, what's been slightly disappointing, finding out ( randomly ) via the website you've been contributing to translations which are better than mine but not updated in the latest "state" of the branch we're supposed to work on...I ended up syncing to try to avoid this, working on the translation, finding out about your version and then deleting mine. I'm aware you're working on lots of other things but it gives a feeling of inefficiency

minimalparts commented 3 months ago

@serpico oh no, then I messed up pushing this. I'm very sorry about that! For what it's worth, I had only added a couple of things to your version, for strings that created issues on the actual site. But I see this is very annoying. I'm leaving the site alone for now, so won't touch anything until you tell me to. My apologies!!

minimalparts commented 3 months ago

@serpico I am looking again at that deployment issue with the captcha, which was one of the reasons I ended up touching the translations in the first place. The strings surrounding the captcha will have to be changed as we modify the general logic (see issue #26 ). But I think the best way to go about it is to first concentrate on the translation and merge things as they are, and then fix the logic, including whatever modifications they require to the strings around the captcha variables. Once the translation branch is as we want it and #26 has been fixed, we can then merge into main and redeploy.

serpico commented 3 months ago

I really appreciate you took the time to address this. I'll try to open a separate issue for the translation of "did you know", that way I could get assigned and when I've done all I can with the translation related to that issue it could be handed over to someone else to fill the last blanks and proofread it.

If you think it's not too much hassle for the benefit it would provide, feel free to modify that issue to improve it, make it clearer, whatever...

And if that works I'll have look at the website stuffs you mentioned here

minimalparts commented 3 months ago

@serpico great idea, thanks for opening the issue, it is indeed much cleaner that way! I have assigned you to it.

A look at the website would be fabulous at some point, but do take a break in-between. You have been doing a lot of translations recently :) And thanks for all your work. We are very grateful!

minimalparts commented 3 months ago

Hey @serpico , I'm sorry, I haven't had time to look into the translations again the past days. Just let me know when you are done with messages.po and did_you_know-fr.txt. I'll merge them so that we can update the website. (And no hurry, of course, I just want to indicate that this is still on my to-do list and I haven't forgotten 🙂)

serpico commented 3 months ago

@minimalparts, first I'd like to commend you for the way you worded this last message, as a beginner contributor everything I could ask for is there.

PS: Is it somehow planned for the user to be able to switch the UI language of a given instance regardless of the instance main target language(s) ( UI could be whatever the user choose while the instance is focused on one or two target languages - as you mentioned on mastodon about the currently running instances, one focused on german content, etc... ) via the profile for example ? I thought as this as a way to more easily realign the translations and more generally the wording all over the UI in order to make them as clear and useful as possible.

minimalparts commented 3 months ago

@serpico fantastic, thank you! I will wait until you are done to merge. It is really nice to have someone look over the original text, because clearly, we have confusions in there that should be corrected in the English as well. So once we have the French translation, I'll use it to check the English too 🙂

And indeed, we would ideally have a way to switch the language of the UI between all translated languages. In principle, it should work because the UI translations are contained within the translations directory while the languages of the actual indexer are set in the .env file, so no conflict. We just haven't had a chance to look into this yet. But it's on the to-do list! (And in fact, I should add it as an issue, so that we don't forget about it.)

Have a nice rest of the week!

serpico commented 3 months ago

@minimalparts some empty strings inside message.po in this PR might already be filled in the version currently online you amended manually.

minimalparts commented 3 months ago

@serpico okay, thank you, no problem. I will grab whatever is missing from the online version (unless you have better suggestions, in which case I'll go for your version... I don't think I speak French as often as you do 🙂 )