search

PeWu / osm-history

OpenStreetMap history viewer
Apache License 2.0
41 stars 11 forks source link

Add JOSM to panel with editors #3

Closed javnik36 closed 8 years ago

javnik36 commented 8 years ago

Could you add link to edit in JOSM via remote control?

I think the most interesting here will be Load&zoom function. Here will be needed bbox calculation of osm object. But when it's too complicated(for me it is :), that's why I'm not PRing), adding just loading an object will be fine.

javnik36 commented 8 years ago

Thanks! You're great! But I have spotted a problem with this function. After clicking on JOSM, apparently pops out JOSM request failed. The link seems Ok(when copy paste it, all is working), but there is a problem with angular? I assume it don't likes the http request, when site is on https.

That's what my Chrome Dev Tools shows: image

It is solvable?

PeWu commented 8 years ago

The problem is that the page is hosted on an HTTPS site and the JOSM link is HTTP. This is the browser that is complaining. There is a workaround: https://pearsonnacommunity.force.com/support/s/article/How-to-display-mixed-content-with-Google-Chrome-Internet-Explorer-or-Firefox-1408394589290 There should be a better way to do it, maybe opening the link in a new tab.

javnik36 commented 8 years ago

Hmmm...ok, thanks for explanation, good to know. Easiest workaround is hosting this on non-https :smiley: