PeWu / topola-viewer

Topola Genealogy Viewer – interactive genealogy visualization
https://pewu.github.io/topola-viewer
Apache License 2.0
213 stars 54 forks source link

Not rendering half siblings #119

Open KentGrigo opened 1 year ago

KentGrigo commented 1 year ago

When not all of the parents are shared, the siblings are not rendered. To reproduce, create Brother, Sister, Half-Brother, Father, and Mother. Select Brother and add the parents, Father and Mother. Add Sister as a sibling. Select Half-Brother and add the parent, Mother, and leave father unknown. When looking at the graph for Brother, Half-Brother is not rendered (even with All Relatives).

KentGrigo commented 1 year ago

I've added a small test to show the issue. Just make a new family tree and import the attached .gramps file (GitHub didn't accept that file ending so I added .txt, just remove it). Also, here are some screenshots of the test.

Note that I've set "View" to "All relatives".

Gramps file topola-viewer-119.gramps.txt

As Brother topola-viewer-119-as-brother

As Mother topola-viewer-119-as-mother

As Half-Brother topola-viewer-119-as-half-brother

PeWu commented 1 year ago

Thanks for the report. Yes, this is an actual problem and unfortunately the fix is not that trivial but definitely doable - requires layout changes in the topola library. See also https://github.com/PeWu/topola-viewer/issues/84 and https://github.com/PeWu/topola/issues/30