search

PeanutBase / jekyll-peanutbase

A "starter" Jekyll site that uses the jekyll-theme-legumeinfo submodule
Apache License 2.0
0 stars 0 forks source link

Gene keyword search enhancements #36

Closed svengato closed 1 year ago

svengato commented 1 year ago

Recent enhancements to the gene keyword search web component include:

I have rebuilt the PeanutBase Jekyll site on another computer, and am ready to do it on dev-pb-jekyll.

  1. Is everyone okay with the list format? Should we do the same for trait keyword search?
  2. The previous search result returned an id from which we could create a link directly to a report page in ArachisMine, but the new results do not. (This applied to gene name, and now also to gene family.) I suggest that we link to an ArachisMine keyword search page instead, then the user can select the desired report page.
sdash-github commented 1 year ago

Is it possible to have a look at it?

On 5/24/23 9:13 AM, svengato wrote:

Recent enhancements to the gene keyword search web component include:

  • Can filter by genus, species, strain
  • Can specify keyword search for gene identifier, description, or gene family id
  • Displays results in a list instead of a table.
  • Results contain more information than just gene name and description: full gene identifier, genus + species + strain, location, gene family.

I have rebuilt the PeanutBase Jekyll site on another computer, and am ready to do it on dev-pb-jekyll.

  1. Is everyone okay with the list format? Should we do the same for trait keyword search?
  2. The previous search result returned an id from which we could create a link directly to a report page in ArachisMine, but the new results do not. (This applied to gene name, and now also to gene family.) I suggest that we link to an ArachisMine keyword search page instead, then the user can select the desired report page.

— Reply to this email directly, view it on GitHub https://github.com/PeanutBase/jekyll-peanutbase/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4A463UZAWMYZ3TEEJKCA3XHYJQJANCNFSM6AAAAAAYNOOFDY. You are receiving this because you were assigned.Message ID: @.***>

svengato commented 1 year ago

Current results look like

gene-search-old

New results look like

gene-search-new

sdash-github commented 1 year ago

New one is certainly better. List vs table.

  1. (List) Should have total no of results and if paginated, the numbers in view.
  2. Is it possible to download the entire result set? (in this case a table format is useful)
  3. For comparison, say by location, a tabular view has an advantage.
  4. Since there are only four cols (id, description, location, gene family) table view can be made not to go beyond screen width and won't hide info without horizontal scrolling.

I am leaning for table view. Please @svengato and @adf-ncgr weigh in.

On 5/24/23 9:18 AM, svengato wrote:

Current results look like

gene-search-old https://user-images.githubusercontent.com/8918336/240633753-25330d05-8bdf-4b88-9b2c-0b4fc3c93acb.png

New results look like

gene-search-new https://user-images.githubusercontent.com/8918336/240633871-ef47f318-0860-4b21-b408-bf83499ab308.png

— Reply to this email directly, view it on GitHub https://github.com/PeanutBase/jekyll-peanutbase/issues/36#issuecomment-1561249836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4A467DP7U6CTQUFLLWJATXHYKDTANCNFSM6AAAAAAYNOOFDY. You are receiving this because you were assigned.Message ID: @.***>

svengato commented 1 year ago
  1. The previous search result returned an id from which we could create a link directly to a report page in ArachisMine, but the new results do not. (This applied to gene name, and now also to gene family.) I suggest that we link to an ArachisMine keyword search page instead, then the user can select the desired report page.

I figured out how to link directly to the report page, so we may as well keep that as it is.

svengato commented 1 year ago

I agree about total number of results and currently displayed results, it looks like now we are only showing the number of results currently displayed (not the total).

One advantage of the list format is less wasted space for rows where gene description is long and other fields are short (the description should not be compressed into a narrow table cell).

svengato commented 1 year ago

We decided that pagination is a low priority for now.

svengato commented 1 year ago

Updated in commit ee6e5eb3a24d7ac26b032b7c2e2c7a5c0fb929b6, then added gene family links to ArachisMine in commit 29d771a48595ac89c209d673e8af6939d13ce2be.