Pear0533 / FLVER_Editor

FLVER Editor 2.0 is a complete re-imagination of the original FLVER Editor model editing tool, designed to modify the FLVER model file format for the mainline FromSoftware series of games.
https://www.patreon.com/theonlypear
24 stars 5 forks source link

Bone weight and parenting incorrect #123

Open iruletheworld opened 3 months ago

iruletheworld commented 3 months ago

Expected behaviour

Unexpected behaviour

Steps to reproduce the unexpected behaviour

  1. Download the files in this link: https://mega.nz/file/8o1XiQgC#63mke2dBFWplrzlaIyL45Fn94Llnl2wSvnjZW2wBYUA
  1. Import the FBX 'Cloud body' using Flver Editor v2.4, select 'c[amsn]_e.matxml' for the MTD, select 'Skin' mode
  2. Flip the YZ axes, save the Flver file
  3. Rename the Flver file to a certain armour piece, e.g., LG_M_1600 for Blaidd's Greaves
  4. Pack the Flver back to DCX using Witchy BND v2.6.1.1
  5. Load the mod and start the game using Mod Engine 2
  6. You should be able to see that the weight for L_Thigh, R_Thigh, L_Forearm and R_Forearm are wrong.
  7. The bones for the belt near the right thigh are parented to R_Thigh, so that the belt would move with the right thigh, this is also wrong
  8. I have also tested 'Static' and 'Single Weight' options during import, neither worked

How do I know this is not caused by the FBX or the Flver file in the RAR?

Why can't I just use Flver Editor v1.97?

Proposed work around

Pear0533 commented 3 months ago

Expected behaviour

  • FBX model bone weight and parenting after import into ER should behave the same as in Blender

Unexpected behaviour

  • Some bone weight and parenting are wrong after import

Steps to reproduce the unexpected behaviour

  1. Download the files in this link: https://mega.nz/file/8o1XiQgC#63mke2dBFWplrzlaIyL45Fn94Llnl2wSvnjZW2wBYUA
  • The FBX file was exported from Blender v3.4.1 using the default export settings
  • The Flver file was downloaded from the Test Data Discord server
  1. Import the FBX 'Cloud body' using Flver Editor v2.4, select 'c[amsn]_e.matxml' for the MTD, select 'Skin' mode
  2. Flip the YZ axes, save the Flver file
  3. Rename the Flver file to a certain armour piece, e.g., LG_M_1600 for Blaidd's Greaves
  4. Pack the Flver back to DCX using Witchy BND v2.6.1.1
  5. Load the mod and start the game using Mod Engine 2
  6. You should be able to see that the weight for L_Thigh, R_Thigh, L_Forearm and R_Forearm are wrong.
  7. The bones for the belt near the right thigh are parented to R_Thigh, so that the belt would move with the right thigh, this is also wrong
  8. I have also tested 'Static' and 'Single Weight' options during import, neither worked

How do I know this is not caused by the FBX or the Flver file in the RAR?

  • I imported the FBX using Flver Editor version 1.97 and the bone weight and parenting worked as expected

Why can't I just use Flver Editor v1.97?

  • Because it doesn't support ray tracing. I tried using Flver Editor v2.4 to open the file modified firstly by v1.97 and then saved a new copy of it, ray tracing still did not work.

Proposed work around

  • Add ability to Flver Editor v2.4 to upgrade files modified by v1.97 to be compatible with ray tracing

Firstly, I'd like to thank you for your thorough issue report, it is extremely helpful and I wish more people took the time to write their reports like this. I'll take a look at the issue as soon as I can and let you know what I find. Thank you again!

Pear0533 commented 3 months ago

Expected behaviour

  • FBX model bone weight and parenting after import into ER should behave the same as in Blender

Unexpected behaviour

  • Some bone weight and parenting are wrong after import

Steps to reproduce the unexpected behaviour

  1. Download the files in this link: https://mega.nz/file/8o1XiQgC#63mke2dBFWplrzlaIyL45Fn94Llnl2wSvnjZW2wBYUA
  • The FBX file was exported from Blender v3.4.1 using the default export settings
  • The Flver file was downloaded from the Test Data Discord server
  1. Import the FBX 'Cloud body' using Flver Editor v2.4, select 'c[amsn]_e.matxml' for the MTD, select 'Skin' mode
  2. Flip the YZ axes, save the Flver file
  3. Rename the Flver file to a certain armour piece, e.g., LG_M_1600 for Blaidd's Greaves
  4. Pack the Flver back to DCX using Witchy BND v2.6.1.1
  5. Load the mod and start the game using Mod Engine 2
  6. You should be able to see that the weight for L_Thigh, R_Thigh, L_Forearm and R_Forearm are wrong.
  7. The bones for the belt near the right thigh are parented to R_Thigh, so that the belt would move with the right thigh, this is also wrong
  8. I have also tested 'Static' and 'Single Weight' options during import, neither worked

How do I know this is not caused by the FBX or the Flver file in the RAR?

  • I imported the FBX using Flver Editor version 1.97 and the bone weight and parenting worked as expected

Why can't I just use Flver Editor v1.97?

  • Because it doesn't support ray tracing. I tried using Flver Editor v2.4 to open the file modified firstly by v1.97 and then saved a new copy of it, ray tracing still did not work.

Proposed work around

  • Add ability to Flver Editor v2.4 to upgrade files modified by v1.97 to be compatible with ray tracing

Would you mind sharing your Discord tag with me? I have some things I'd like to share with you regarding this issue.

iruletheworld commented 3 months ago

Expected behaviour

  • FBX model bone weight and parenting after import into ER should behave the same as in Blender

Unexpected behaviour

  • Some bone weight and parenting are wrong after import

Steps to reproduce the unexpected behaviour

  1. Download the files in this link: https://mega.nz/file/8o1XiQgC#63mke2dBFWplrzlaIyL45Fn94Llnl2wSvnjZW2wBYUA
  • The FBX file was exported from Blender v3.4.1 using the default export settings
  • The Flver file was downloaded from the Test Data Discord server
  1. Import the FBX 'Cloud body' using Flver Editor v2.4, select 'c[amsn]_e.matxml' for the MTD, select 'Skin' mode
  2. Flip the YZ axes, save the Flver file
  3. Rename the Flver file to a certain armour piece, e.g., LG_M_1600 for Blaidd's Greaves
  4. Pack the Flver back to DCX using Witchy BND v2.6.1.1
  5. Load the mod and start the game using Mod Engine 2
  6. You should be able to see that the weight for L_Thigh, R_Thigh, L_Forearm and R_Forearm are wrong.
  7. The bones for the belt near the right thigh are parented to R_Thigh, so that the belt would move with the right thigh, this is also wrong
  8. I have also tested 'Static' and 'Single Weight' options during import, neither worked

How do I know this is not caused by the FBX or the Flver file in the RAR?

  • I imported the FBX using Flver Editor version 1.97 and the bone weight and parenting worked as expected

Why can't I just use Flver Editor v1.97?

  • Because it doesn't support ray tracing. I tried using Flver Editor v2.4 to open the file modified firstly by v1.97 and then saved a new copy of it, ray tracing still did not work.

Proposed work around

  • Add ability to Flver Editor v2.4 to upgrade files modified by v1.97 to be compatible with ray tracing

Would you mind sharing your Discord tag with me? I have some things I'd like to share with you regarding this issue.

Sure, my Discord is realshintheweapon