search

PearlCat / teacozy

0 stars 0 forks source link

Project Review #1

Open GitMazzone opened 7 years ago

GitMazzone commented 7 years ago

Your opening <html> tag is missing the opening bracket < :
https://github.com/PearlCat/teacozy/blob/master/index.html#L1

Putting the header inside of your main div caused it to not span the full page width:
https://github.com/PearlCat/teacozy/blob/master/index.html#L14-L23

Your address-section isn't actually 500px tall. One solution is to account for the margin you added to the top and make the height 570px:
https://github.com/PearlCat/teacozy/blob/master/resources/css/style.css#L102-L111

Changing your footer width to 100% will fix the width issue:
https://github.com/PearlCat/teacozy/blob/master/resources/css/style.css#L156

PearlCat commented 7 years ago

Hi, I just use development tool to check, the 'address-section' is 500px tall. Do I have to take account of a top margin, or just a top padding?

Thanks.