PearlynnT / pe

0 stars 0 forks source link

Incorrect phone number accepted #3

Open PearlynnT opened 7 months ago

PearlynnT commented 7 months ago

There should be a check on the number on digits for the phone number (by convention, phone number has 8 digits). I managed to add a person with a 7 digit phone number. This may cause users to have the incorrect contact details keyed in. Screenshot 2023-11-17 at 4.19.37 PM.png

nus-pe-bot commented 7 months ago

Team's Response

Thank you for bringing this up.

We have to admit that not all countries have 8 digit phone numbers. Hence, 7 digit phone numbers are possible, for example if our user is saving a connection/recruiter from overseas.

In addition, this does not seem like a documentation bug.

That being said, it is possible that we can handle these scenarios better by adding warnings, etc.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No upper bound on phone number

Ok tbh I not very sure if this is a bug but there's no upper bound on the phone number

possible that user accidentally holds down a number

I added 9876543211111111111111111111111 and it worked


[original: nus-cs2103-AY2324S1/pe-interim#4448] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this out! We can consider having a warning for this kind of uncommonly long phone numbers.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** The team's target user for the product is SoC students who will be extension be based in Singapore and have a Singapore phone number. The format of phone numbers in Singapore is 8 digits. I believe that a check for the valid format of phone numbers is important in the case of the users keying in an invalid phone number which would make it difficult for the person to be contacted. (a user may miss out typing the last digit of the phone number and a 7 digit phone number will render the person uncontactable via phone)