Open PearlynnT opened 7 months ago
Thank you for pointing this out.
It is possible for such emails to be valid. Please refer to this thread on stackoverflow: https://stackoverflow.com/questions/20573488/why-does-html5-form-validation-allow-emails-without-a-dot
That being said, we might consider adding warnings for uncommon patterns in email. But it is considered less important considering what we've implemented so far. Thus, it is out of scope.
Team chose [response.NotInScope
]
Reason for disagreement: This is a website that lists the possible valid/invalid email domains: https://help.xmatters.com/ondemand/trial/valid_email_format.htm
In this screenshot taken from the website, the example shows that invalid email domains would include abc.def@mail
which is similar to the invalid email (johnp@example
) which I ran in the command.
I do not believe that this issue is "less important" as an invalid email keyed in by the user will make it difficult for the user to be contacted.
Invalid email domain is accepted when adding a person. I typed in
johnp@example
but valid email domains need to have a.com
so there isn't a check to check for invalid emails. This may cause users to accidentally key in the wrong contact details.