PearlynnT / pe

0 stars 0 forks source link

Incorrect email accepted when adding a person #4

Open PearlynnT opened 7 months ago

PearlynnT commented 7 months ago

Invalid email domain is accepted when adding a person. I typed in johnp@example but valid email domains need to have a .com so there isn't a check to check for invalid emails. This may cause users to accidentally key in the wrong contact details.

Screenshot 2023-11-17 at 4.21.10 PM.png

soc-pe-bot commented 7 months ago

Team's Response

Thank you for pointing this out.

It is possible for such emails to be valid. Please refer to this thread on stackoverflow: https://stackoverflow.com/questions/20573488/why-does-html5-form-validation-allow-emails-without-a-dot

That being said, we might consider adding warnings for uncommon patterns in email. But it is considered less important considering what we've implemented so far. Thus, it is out of scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is a website that lists the possible valid/invalid email domains: https://help.xmatters.com/ondemand/trial/valid_email_format.htm

In this screenshot taken from the website, the example shows that invalid email domains would include abc.def@mail which is similar to the invalid email (johnp@example) which I ran in the command. Screenshot 2023-11-23 at 10.49.25 PM.png

I do not believe that this issue is "less important" as an invalid email keyed in by the user will make it difficult for the user to be contacted.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]