PearlynnT / pe

0 stars 0 forks source link

Able to add an internship with a backdated scheduled interview time #6

Open PearlynnT opened 7 months ago

PearlynnT commented 7 months ago

I put in the year 2022 for the scheduled interview time and the command still worked. There should be a check for invalid year. The UG should clearly state that the date should be a future date.

Screenshot 2023-11-17 at 4.29.10 PM.png Screenshot 2023-11-17 at 4.29.30 PM.png

soc-pe-bot commented 7 months ago

Team's Response

Hi, thanks for the report.

We are rejecting this.

It is perfectly fair to allow a user to add an internship, whose interview has already passed, as the purpose of our app is to track internships as a whole, not just track when their interview date is. So if I just attended a Google interview this morning, I should still be able to add it in, as I would like to track the other details (e.g. internship description) as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that it is not meaningful for the user to add an internship interview time when the interview is already over as there is no need to track the exact timing of when the interview occured if it is in the past. Moreover, there is no reason for the user to track an internship interview that happened the previous year (or many years before), so a check on the validity of the year will ensure that the user does not key in the wrong information which also helps to ensure the accuracy of the information on the system.