Open PearlynnT opened 7 months ago
[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Hi, thanks for bringing this to our attention.
The "Next" field intends to show the NEXT UPCOMING INTERNSHIP. Therefore if the internship date is in the past, it rightfully will not be shown in the Next field of the list UI, quoting from our UG:
List of Companies: Displays brief details of every company added. The index, name, tags and the date of the next internship interview (represented by the “Next:” field) for each company are displayed here.
In addition, we also have a view function that can check if an internship is added correctly, and an edit internship function which can edit the wrongly inputted interview time.
sort
command is independent from the "Next:" field. It does the following, which we also documented in our UG:
[The team marked this bug as a duplicate of the following bug]
App allows for addition of internships with scheduled times in the past, but does not update UI
Here, I typed 2022 instead of 2023, a common typo that might occur without the user realising. However, it does not update the UI on the list, and when sort is used, it appears at the front. This may confuse users and hinder their usage.
[original: nus-cs2103-AY2324S1/pe-interim#1407] [original labels: type.FunctionalityBug severity.Medium]
[This is the team's response to the above 'original' bug]
Hi, thanks for bringing this to our attention.
The "Next" field intends to show the NEXT UPCOMING INTERNSHIP. Therefore if the internship date is in the past, it rightfully will not be shown in the Next field of the list UI, quoting from our UG:
List of Companies: Displays brief details of every company added. The index, name, tags and the date of the next internship interview (represented by the “Next:” field) for each company are displayed here.
In addition, we also have a view function that can check if an internship is added correctly, and an edit internship function which can edit the wrongly inputted interview time.
sort
command is independent from the "Next:" field. It does the following, which we also documented in our UG:
- Filters out all companies with internships in the given date range
- Sort the companies by the one having the earliest internship interview time in that date range.
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your reason]
Ran
sort c
The first on the company list is Google, where I previously added an internship under the company but the UI doesn't display the date, which would confuse users who run the sort command but a company without a date is still displayed