search

PearsonEducation / Alarmageddon

Full-stack monitoring and alerting Python library.
Other
15 stars 10 forks source link

Kafka validator #2

Closed curtisallen closed 9 years ago

curtisallen commented 9 years ago

Adds a validator that uses the kafka-list-topic command to determine if the kafka cluster is running sub-optimally. Meaning there are multiple leaders for a single data partition.

scotthellman commented 9 years ago

The code looks good Curtis, thanks!

A few things before we can merge: As far as pep8 compliance goes, there's some trailing whitespace on some lines that needs to be cleaned up. Also, the indentation amounts don't match the rest of Alarmageddon. Each level should be 4 spaces.

The sphinx docs need to be updated. If you could add a short example to doc/validations.rst that would be awesome. Similarly, we'll need a Kafka entry in alarmageddon.validations.rst. The respective Cassandra sections of those documents will be good references.

Thanks for putting this together!

curtisallen commented 9 years ago

Thanks @scotthellman , I think I've fixed these issues with the exception of line to long PEP8 warnings. Thanks for your feedback!