PearsonEducation / Alarmageddon

Full-stack monitoring and alerting Python library.
Other
15 stars 10 forks source link

Inconsistent use of validation in SshCommandExpectation #23

Open scotthellman opened 7 years ago

scotthellman commented 7 years ago

We include the validation in the constructor for SshCommandExpectation, but then appear to use it inconsistently:

https://github.com/PearsonEducation/Alarmageddon/blob/dev/alarmageddon/validations/ssh.py#L309 vs https://github.com/PearsonEducation/Alarmageddon/blob/dev/alarmageddon/validations/ssh.py#L307

We should either always use self.validation or always have the validation as a parameter to SshCommandExpectation's methods.