Teams publisher - Githubissues

PearsonEducation / Alarmageddon

Full-stack monitoring and alerting Python library.

Other

15 stars 10 forks source link

Teams publisher #28

Closed jestin1005 closed 5 years ago

jestin1005 commented 5 years ago

Creating publisher for Microsoft Teams

JeffreyDeYoung commented 5 years ago

@timjstewart -- could you double check this prior to merge?

scotthellman commented 5 years ago

Thanks for the PR @jestin1005 ! I think it looks good overall.

We do need unit tests (in tests/publishing/test_teams.py) before we can merge. The tests in test_slack.py are a good reference. We need at least tests for the TeamsPublisher corresponding to:

test_repr
test_str
testSendSuccess
testSendFailure
test_publish_failure

Once that's taken care of and this PR is merged, I can do a release so that the changes will be available in pypi.

JeffreyDeYoung commented 5 years ago

@scotthellman -- thanks for checking!

jestin1005 commented 5 years ago

Closing this, will be creating a new one with #28 and #28 merged