PearsonEducation / Alarmageddon

Full-stack monitoring and alerting Python library.
Other
15 stars 10 forks source link

Validation passed to Expectations inconsistently #4

Open scotthellman opened 9 years ago

scotthellman commented 9 years ago

Most expectations take a validation upon construction, but http expectations take a validation through their validate method, and ssh expectations take validations at both times. For consistency and to ensure that we don't report two different expectations as being the same (eg to pagerduty), we need to have our expectations all using the same pattern.

Passing in a validation at construction seems like the best option, for the above-mentioned pagerduty reason.