PearsonEducation / Alarmageddon

Full-stack monitoring and alerting Python library.
Other
15 stars 10 forks source link

Superclass init handled inconsistently #6

Closed scotthellman closed 9 years ago

scotthellman commented 9 years ago

We're currently invoking the init of a superclass in two ways, either by invoking super() or by explicitly calling the parent class init.

eg

super(HttpValidation, self).__init__
SshCommandExpectation.__init__(self, validation)

We need to update our classes to be consistent about this, although which approach is better given Alarmageddon's class structure is something we'll have to decide on.

scotthellman commented 9 years ago

Switched to explicit __init__ calls as of 2a0d8a6e