search

PeasantFoundry / Mechtrauma

Mechtrauma for Barotrauma
13 stars 12 forks source link

Mechtrauma Config Port Problems #55

Closed PeasantFoundry closed 1 year ago

PeasantFoundry commented 1 year ago

  1. Oil Base DPS is spelled phonetically and it wasn't intended to be an initial config option, instead Oil Filtration efficiency was. image

  2. Oil Filtration Efficiency is not included in the settings.

  3. Service life for Oil Filters is included twice: image image

  4. Float Loveliness! can we round these for display and save? image

MapleWheels commented 1 year ago
  1. Is proper intended behaviour. #barodevmoment.
  2. Oil Filtration Life is listed as "Standard Oil Filter Service Life" as that was what it's original display name was in the old config. It's just mixed up, see 3.
  3. Is an error on my part, left the value empty so it autofilled to internal name. image
  4. Will need to be fixed in the next version of MTK. It's an issue caused by the vanilla GUI Slider.
PeasantFoundry commented 1 year ago
  1. Not quite:

-- oil Filtration Efficieny / Oil Deterioration Modifier GUI.TextBlock(GUI.RectTransform(Vector2(1, 0.05), category.Content.RectTransform), "Oil Filtration Efficiency Rating (%)", nil, nil, GUI.Alignment.Center, true).ToolTip = "This determines how long filtered oil will last in machines. A 100% efficiency rating will eliminate oil deterioration." -- oil Deterioration group local oilFiltrationEPG = GUI.LayoutGroup(GUI.RectTransform(Vector2(1.0, 0.1), category.Content.RectTransform), true, GUI.Anchor.TopLeft) --oil sprite local oilFiltrationES = ItemPrefab.GetItemPrefab("oil_can").InventoryIcon local image = GUI.Image(GUI.RectTransform(Vector2(0.1,1.0), oilFiltrationEPG.RectTransform), oilFiltrationES) image.ToolTip = "Oil Can" -- oil Deterioration Setting (multiplier) local oilFiltrationEP = GUI.NumberInput(GUI.RectTransform(Vector2(0.9,0.1), oilFiltrationEPG.RectTransform), NumberType.Float) oilFiltrationEP.valueStep = 1.0 oilFiltrationEP.MinValueFloat = 1.0 oilFiltrationEP.MaxValueFloat = 100.0 oilFiltrationEP.FloatValue = MT.Config.oilFiltrationEP oilFiltrationEP.OnValueChanged = function () MT.Config.oilFiltrationEP = oilFiltrationEP.FloatValue MT.Config.oilFiltrationM = MT.Config.oilFiltrationEP / 100 OnChanged() end

MapleWheels commented 1 year ago

Fixed in local dev image

PeasantFoundry commented 1 year ago

Alright, everything seems to be going smoothly now!