nimporter.py - fixed excluded_dirs, added corresponding test/proj3

Pebaz / nimporter

Compile Nim Extensions for Python On Import!

MIT License

824 stars 33 forks source link

nimporter.py - fixed excluded_dirs, added corresponding test/proj3 #30

Closed phdye closed 3 years ago

phdye commented 4 years ago

build_nim_extensions's exclude_dirs argument had no effect. Here is a fix.

phdye commented 4 years ago

Odd failure: Error: Command failed: choosenim 1.0.6

It does not appear to relate to the change I made.

phdye commented 4 years ago

Latest commit removed the exclude_dirs fix to see if the CI errors still occurred. And they do.

What would you like me to do ?

Pebaz commented 4 years ago

First off, thank you very much for taking the time to file an issue as well as create a pull request!

I'm sorry for the late reply! I will look into this and see why this is failing as well as the details surrounding the error you are getting with exclude_dirs.

What I know so far is that the jobs are failing when trying to install Nim and not in the actual tests.

I will get back to you within the next couple of days!

phdye commented 4 years ago

Restored fix so that it will be ready when the CI issue is resolved.

Pebaz commented 4 years ago

Hello @phdye !

Have you had a chance to review the requested changes?

If you won't be able to get to it no worries at all just let me know if you can! 😄

Pebaz commented 3 years ago

Fix provided in 1.0.3 release.