Add FLTO and Strip - Githubissues

Pebaz / nimporter

Compile Nim Extensions for Python On Import!

MIT License

824 stars 33 forks source link

Add FLTO and Strip #35

Closed juancarlospaco closed 3 years ago

juancarlospaco commented 3 years ago

Add FLTO (Faster Binaries) and Strip (Smaller Binaries) to Nimporter using Nim built-in defines.
2 Lines Diff.

Pebaz commented 3 years ago

Awesome! Thanks!

Benjamin-Lee commented 3 years ago

Nice work! Are these symbols defined here (https://github.com/nim-lang/Nim/pull/14013)? I've never seen them be passed as -d: options so that's super cool.

juancarlospaco commented 3 years ago

Yes they are builtin on Nim itself.

Benjamin-Lee commented 3 years ago

Sweet. Thanks for the PR! I couldn't find those flags defined anywhere in the docs so I'm impressed.

juancarlospaco commented 3 years ago

They live on the CFG of the compiler I think.

Keithcat1 commented 3 years ago

I added those flags recently. There's a known issue with Mack, but I've submitted a PR and it should get fixed eventually. I didn't think people would start using these flags quite so quickly, but then again, they do make quite a difference sometimes.