Pebaz / nimporter

Compile Nim Extensions for Python On Import!
MIT License
824 stars 33 forks source link

Check if the user is using 64Bit Python #36

Closed juancarlospaco closed 3 years ago

juancarlospaco commented 3 years ago

Sometimes noobs install 32Bit Nim or 32Bit Python on 64Bit OS, no new 32Bit hardware for PC been built since the 90's.

Some people come from scripting interpreted languages, and been using 32Bit out of habit until today, when your code runs inside a virtual machine theres no difference, but for native machine code it does.

Nowadays all PC are 64Bit hardware, theres no modern 32Bit PC, most likely they should be using 64Bit.

Pebaz commented 3 years ago

I'm a bit concerned that this will needlessly limit Nimporter to use only 64-bit tooling. I have not been able to test and see if it works with 32-bit software. Can you test and see if it works with 32 bit software in the first place? When a compilation fails, I already show the different architectures of all the tools so I'm not sure if this is a good solution or if a better one exists like updating the readme to say to only use 64 bit. The other thing is that this patch only checks for 32 bit Python and not 32 bit Nim or 32 bit GCC/Clang/MSVC.

juancarlospaco commented 3 years ago

Ok :+1:

Pebaz commented 3 years ago

Thanks for the attention to detail and thoughts about improving user experience! 😃