Closed daylinmorgan closed 1 year ago
@SekouDiaoNlp this seems reasonable. If you have time, could you look into making this optional?
@SekouDiaoNlp this seems reasonable. If you have time, could you look into making this optional?
Hey @Pebaz what's up? Yes it is indded reasonable, didn't realize cookiecutter was so fat lol.
I can look into it tomorrow.
Fyi, I setup a windows box on aws this weekend and will be able to investigate the windows build issue.
Cheers.
Hi @daylinmorgan.
Thank you for reaching out and suggesting to move cookiecutter to an optional dependency.
The changes have been pushed to the version 2.0.0rc branch.
The stock install via pip install nimporter
now leaves out cookie cutter and library authors can install the extra dependencies via pip install nimporter[cli]
.
Thanks again for your suggestion.
Cheers,
@SekouDiaoNlp.
Great! Thanks for taking care of this so quickly. I'll be sure to use the rc branch while exploring integrating it in my projects to see if I come across any other issues.
Is your feature request related to a problem? Please describe.
Cookiecutter
doesn't seem to be needed at runtime.Describe the solution you'd like
Use an extras dependency (i.e.
pip install "nimporter[cli]"
) inpyproject.toml
for library authors to access the functionality.Describe alternatives you've considered
Alternative is leaving it as is which means extra dependencies for end-users. Though maybe there is some component outside the CLI that requires
cookiecutter
I'm missing.Additional context
There is a non-trivial list of
cookiecutter
dependencies:Keeping
nimporter
deps slim may be inline with library authors wanting lightweight extension modules.Thanks for the awesome work melding
python
andnim
!