search

PebbleTemplates / pebble

Java Template Engine
https://pebbletemplates.io
BSD 3-Clause "New" or "Revised" License
1.09k stars 166 forks source link

Generate OSGi metadata into pebble jar to make it OSGi compliant #663

Closed HannesWell closed 10 months ago

HannesWell commented 10 months ago

This allows to use the pebble jar in an OSGi runtime, like Eclipse, out of the box.

The version ranges for the optional dependencies com.github.ben-manes.caffeine:caffeine, javax.servlet and jakarta.servlet have been widened manually because there are newer versions available than the one this library depends on.

If you are interested in updating any of these dependencies (and especially migrate javax.servlet:servlet-api to javax.servlet:javax.servlet-api or even jakarta.servlet:jakarta.servlet-api:4.0.2 (which provides the javax.servlet packages) I can provide a separate PR or do it in this one.

The OSGi compliant MANIFEST.MF is only generated for the main pebble artifact. If you think this is also relevant for the spring artifacts I can extend the change, but I would not be able to test the result.

HannesWell commented 10 months ago

@ebussieres could you please have a look at this?

HannesWell commented 10 months ago

Thank you @ebussieres for accepting this. Do you already have some idea when the next release will happen?

ebussieres commented 10 months ago

I'll make one today

HannesWell commented 10 months ago

I'll make one today

Awesome. Thanks again!

ebussieres commented 10 months ago

@HannesWell : Release has been made.