Refactoring and fix. - Githubissues

Pecacheu / Elevators-v2

Adds fully-featured Elevators to Minecraft!

GNU General Public License v3.0

10 stars 10 forks source link

Refactoring and fix. #12

Closed dretax closed 4 years ago

dretax commented 5 years ago

@Pecacheu If you don't mind i have done some refactoring. I am really suggesting your to switch to IntellIJ IDEA instead of Eclipse, and start using maven. (I can help you with that.)

Aside of that I have done fixes, but I haven't been able to create an elevator yet. Seems like the sign is remaining as "Error"

dretax commented 5 years ago

Opening only works for metal doors at the moment. Some API needs to be updated to the current spigot version, but it seems fine now. Elevators v2.zip

tkf0 commented 5 years ago

How difficult would it be to re-enable glass doors? My whole server relies on elevators using doors of said material :D

dretax commented 5 years ago

I'll see to It, haven't checked It yet.

dretax commented 5 years ago

@tkf0 Update your config.

Following sections are important: blockList: IRON_BLOCK: 8 GOLD_BLOCK: 10 EMERALD_BLOCK: 12 DIAMOND_BLOCK: 15 LEGACY_STAINED_GLASS: 5 GLASS: 4

doorBlock: 'GLASS_PANE' # Material used for elevator block-doors.

dretax commented 5 years ago

Elevators v2.zip

OverDhill commented 5 years ago

Got the basics working but seen this error in log.

Error while loading config!

No enum constant org.bukkit.Material.STAINED_GLASS

dretax commented 5 years ago

@OverDhill

OverDhill commented 5 years ago

Thanks.... it is working great

tkf0 commented 5 years ago

@dretax I got it working! Thank you!

Would it be possible to fix the doors/glass panes not properly "connecting"/attaching to the adjacent blocks (stone here)?

Here's my current config:

blockList:
  WHITE_WOOL: 12
  IRON_BLOCK: 12
  GLASS: 12

doorBlock: 'GLASS_PANE'

tkf0 commented 5 years ago

Also, while just a minor bug, there seems to be an encoding issue:

minorbug

Smxxthy commented 5 years ago

I noticed a bug that when the elevator is told to go to another floor, if you are using doors, then the doors open and close really quickly once. This seems to be causing lag for all players.

dretax commented 5 years ago

Interesting, I didn't get those encoding issues. I'll take a look at these soon.

Pecacheu commented 4 years ago

Ahh I can't believe I didn't accept this pull forever ago, I thought I had. Anyhow someone convinced me to start playing Minecraft again, I'll have a look at it and see how it goes on 1.15.x

Pecacheu commented 4 years ago

Well there seem to be a few issues getting it to compile for 1.15, however the pull is closer than it was before.

Unfortunately the formatting of the files is completely messed up, making diff-checking an absolute pain, so I expect it to take a few days to work through everything, however after I get things working I'll accept the pull and release a 1.15 version.

dretax commented 4 years ago

Let me know. I dropped MC again. xD