search

Pecacheu / Elevators-v2

Adds fully-featured Elevators to Minecraft!
GNU General Public License v3.0
10 stars 10 forks source link

1.18.2 Stops new elevators from being created #21

Closed LXManiac closed 2 years ago

LXManiac commented 2 years ago

Old elevators work fine but new ones cannot transfer sign to Elevators v2. Says no elevator detected.

Pecacheu commented 2 years ago

Which plugin version are you using? Config file saving bug should've been fixed in v3.3.2

LXManiac commented 2 years ago

I'm using the latest version (3.3.2) but it still has an error sign. I tried it at different heights above y+0 and nothing. Elevator Issue \

Pecacheu commented 2 years ago

That's super weird. Check the console though, the > ERROR < on the sign means that there was an internal Java error, otherwise the sign would show [???] if you created the elevator wrong in some way.

Pecacheu commented 2 years ago

Also I'm working on another big update with some new features and a lot of code optimization. So once that's done you can try that version. I seem to be able to create new elevators fine in the beta.

LXManiac commented 2 years ago

Here is the error in the console. Also really glad there is gonna be new features. Looking forward to it. Elevator Error.txt

Pecacheu commented 2 years ago

Seems like the code was expecting the elevator sign data to be there, and when attempting to get the min/max height of the elevator shaft it tries to pull up a sign block that doesn't exist.

But the elevator creation and new sign column creation routines (yes you can have multiple elevator signs per floor, and they'll line up neatly) are some of the things I overhauled, so hopefully this has now been fixed, but we'll see