PecanProject / bety

Web-interface to the Biofuel Ecophysiological Traits and Yields Database (used by PEcAn and TERRA REF)
https://www.betydb.org
BSD 3-Clause "New" or "Revised" License
16 stars 38 forks source link

sites value constraints: needed cleanup and decisions #246

Open gsrohde opened 9 years ago

gsrohde commented 9 years ago

city, state, country

See discussion at https://www.overleaf.com/2086241dwjyrd#/5297403/.

soil

Right now, there are 31 distinct descriptors, but many of these are the same if variations in capitalization and whitespace are ignored.

If we restrict this, anomalous information could go into the soilnotes column.

UPDATE: There are 7 distinct non-empty values that aren't in the list. Here they are along with possible updated values:

"loamsandy" --> sandy loam
"peat" --> ???
"sandloamy" --> sandy loam
"Nodaway silt loam" --> silty clay loam???
"loamclay" --> clay loam
"loamsilt" --> silt loam
"Sandy clay orthic A, Pedo calanic B, RSA: Swartland form, Swartland series, USDA: ALFISOL RHODOXERAL" --> ???

som

Obviously any percentage like this must be in [0, 100], but the maximal occurring value is only 3.50 right now, so a better upper bound might be reasonable.

greenhouse

There are 272 rows where this is NULL. We'd have to decide how to assign these if we make this column NOT NULL.

local_time

This is an integer, so we can't represent all time zones. See discussion at https://www.overleaf.com/2086241dwjyrd#/5297403/.

geometry

See discussion at https://www.overleaf.com/2086241dwjyrd#/5297403/. At the very least, some restriction on the altitude extracted from this might be possible. And there should be some consistency checks possible between this value and other columns such as local_time and country.

gsrohde commented 9 years ago

@dlebauer Can existing NULL greenhouse values be changed to FALSE?

gsrohde commented 9 years ago

@dlebauer Did you read my comments on the problem of using an integer for local_time?

gsrohde commented 9 years ago

@dlebauer I have a constraint clay_pct + sand_pct <= 100. Should som be included? That is, should clay_pct + sand_pct + som <= 100

dlebauer commented 9 years ago

no, SOM often is not included. This is "percent of mineral fraction" (mineral excludes organic)

i.e. sand+silt+clay is defined as 100%