Open echeng7 opened 9 years ago
@echeng7
Problems:
I have fixed all the problems above. I don't know if it is just me but I keep getting an error when I check the bulk upload with rows 408, 409, 414, and 415. The cultivars are copied straight from the database with their respective species onto the spreadsheet but when it is uploaded, it changes. Can you look into this for me?
@gsrohde
@echeng7 The problem in rows 408 and 414 is that although the cultivar name "Wedesbuttel 95 x Turesson 141" exists in the database, it is associated with the species "Populus tremula × tremuloides", whereas the upload file uses the species name "P. tremuloides × P. tremula". Although the latter is a valid species name (i.e., it is listed in the species table in the database), it isn't the species name the cultivar in question is associated with. (Those two species names probably are actually different designations for the same species, but we'll leave that question aside for now.)
Similarly, in rows 409 and 415, the cultivar name "Ihlendiek 3 x Wedesbuttel 66" is in the database, but it is associated with the species with name "P. tremuloides × P. tremula" whereas the data sheet calls this "Populus tremula × tremuloides".
I think the correct solution here is to change the species name in those four rows to match what the database says is the species name corresponding to those cultivars, but please verify this with David.
I think the "mouseover" error message here needs to be changed. Instead of saying "Not found in cultivars table" it should say something like "cultivar name doesn't match species given", and the error message "Not found in cultivars table" should only be used if there is no cultivar at all in the database with that name, no matter what the species.
@dlebauer
Yes, Scott's solution - change the species name - sounds correct to me
On Monday, May 11, 2015, echeng7 notifications@github.com wrote:
@dlebauer https://github.com/dlebauer
— Reply to this email directly or view it on GitHub https://github.com/PecanProject/bety/issues/275#issuecomment-101039539.
@gsrohde this dataset is ready to go.
I get a few errors on ebi-forecast. I think you must have modified a species name on pecandev but not on the live site. I assume the solution is to change "Populus tremuloides × tremuloides" to "p. tremuloides × p. tremuloides" so as to match the CSV file. Do you want me to do this? Did you have to change anything else?
I changed it to "Populus tremuloides × tremuloides" in the csv file instead of changing the database again.
OK, this is uploaded now. Again, I need to know what more to do with this set.
Just so you don't get alarmed, I should mention I've been setting the date for these sets to 1000-01-01 since I've been assuming we will copy data from the new rows to the old rows but won't copy the date column values.
I've updated the old rows and deleted the new ones.
The scripts I used to do this, and a dump of the old rows before and after the updates is stored on ebi-forecast at /home/n-z/srohde/BETYdb_database_maintenance/poplar_bulk_upload/SQL-fixes
.
Data are in the all.yielddata Google doc spreadsheet here: https://docs.google.com/a/illinois.edu/spreadsheets/d/1hrvMTMc7scvQFgit7QqF68vfxxNufNC--3RJfSDhne4/edit#gid=1338120831
Yields have been updated as much as they can be. Again, ignore the grayed out ones. Thanks!
@dlebauer @gsrohde