PecanProject / bety

Web-interface to the Biofuel Ecophysiological Traits and Yields Database (used by PEcAn and TERRA REF)
https://www.betydb.org
BSD 3-Clause "New" or "Revised" License
16 stars 38 forks source link

Link to CF guidelines in BETYdb resolves to local link - but should resolve to a full address #362

Closed serbinsh closed 8 years ago

serbinsh commented 9 years ago

Or, we should provide the web page in the BETYdb distribution. For example, on our server it resolves to:https://modex.bnl.gov/guidelines.html but we don't have the html file. Can we change this to resolve to https://www.betydb.org/guidelines.html? @dlebauer

gsrohde commented 9 years ago

It's in the Github repository (https://github.com/PecanProject/bety/blob/master/public/guidelines.html) so you should have it. It should be in the /public directory under the Rails root folder.

dlebauer commented 9 years ago

@gsrohde and @robkooper this seems to be part of a bigger problem resolving relative links in the ebi-forecast instance compared to other instances. Another example is the /schemas page, which gives 404, e.g. here: http://pecandev.igb.illinois.edu/bety/schemas

What is the easiest solution?

On Thu, Oct 29, 2015 at 2:25 PM, Scott Rohde notifications@github.com wrote:

It's in the Github repository ( https://github.com/PecanProject/bety/blob/master/public/guidelines.html) so you should have it. It should be in the /public directory under the Rails root folder.

— Reply to this email directly or view it on GitHub https://github.com/PecanProject/bety/issues/362#issuecomment-152293987.

gsrohde commented 9 years ago

@dlebauer The problem with the schemas page has nothing to do with relative links ... the 404 just means I never bothered generated the schema documentation on Pecandev. (I didn't think it necessary, but can do so if it would be useful.)

Most of the resolving-relative-links problems we have had in the past arose because links were hard-coded and didn't use the Rails-aware link_to function for generating link URLs or because the link_to function was used incorrectly—these links wouldn't resolve correctly when Bety was deployed to something like http://hostname/bety instead of just http://hostname. Shawn's problem is a case of the link_to function being used incorrectly and I will fix it.

gsrohde commented 9 years ago

Update: This was fixed on the "Editing Variable" pages but not on the "New Variable" pages (see issue #308).

(@serbinsh Let me know if you find otherwise, that is, if the "CF Guidelines" on the "Editing Variable" page doesn't work in your copy of BETYdb.)

dlebauer commented 8 years ago

@serbinsh does this work now?

gsrohde commented 8 years ago

Fixed in release 4.5.